fix: use startRun in single-type filter E2E test to avoid LLM flakiness#609
Merged
fix: use startRun in single-type filter E2E test to avoid LLM flakiness#609
Conversation
The --filter completeRun test consistently fails because completeRun is only emitted after a successful LLM call. When the LLM errors (common under concurrent test load), the runtime emits stopRunByError instead, which the filter blocks, resulting in zero events with exit code 0. Switch to --filter startRun which is emitted before any LLM calls, making the test reliable while still validating the single-type filter mechanism. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
FL4TLiN3
force-pushed
the
fix/e2e-filter-test-startrun
branch
from
da2174d to
a4f6fec
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--filter completeRunE2E test consistently fails (4 consecutive failures onchangeset-release/main) becausecompleteRunis only emitted after a successful LLM callstopRunByErrorinstead, which the filter blocks, resulting in zero events with exit code 0--filter startRunwhich is emitted before any LLM calls, making the test reliable while still validating the single-type filter mechanismRoot cause
The
stoppedByErrorcheckpoint status doesn't cause a non-zero exit code (onlyPerstackErrordoes), so the test sees exit code 0 but zero filtered events.Test plan
🤖 Generated with Claude Code